ADIOS2: Fix BTD Particle Resize w/ Empty Ranks #3657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ax3l
added
bug
ax3l
added
component: third party
ax3l
changed the title
ax3l
force-pushed
the
fix-btd-resize-adios2
branch
from
e92ad14
to
b38a40f
Compare
For ADIOS2 BP4 and BP5 writes, setting an update of a variable's (openPMD record's) shape is not sufficient to drop all meta-data on disk. In situations where the last write to a BTD stage only adds further particles from a few ranks, we need to pad with zero-block writes so ADIOS2 `Put` gets called. Backend details: - BP4 (as of ADIOS 2.8): last MPI rank's `Put` meta-data wins - BP5 (as of ADIOS 2.8): everyone has to write an empty block
ax3l
force-pushed
the
fix-btd-resize-adios2
branch
from
b38a40f
to
bc3cc55
Compare
ax3l
commented
Feb 1, 2023
ax3l
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
ax3l
force-pushed
the
fix-btd-resize-adios2
branch
from
ff405b0
to
68d1400
Compare
Compact and general, including MR situations.
ax3l
force-pushed
the
fix-btd-resize-adios2
branch
from
68d1400
to
d1967a5
Compare
This was referenced Feb 2, 2023
ax3l
changed the title
RemiLehe
approved these changes
Feb 2, 2023
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For ADIOS2 BP4 and BP5 particle BTD writes, setting an update of a variable's (openPMD record's) shape is not sufficient to drop all meta-data on disk. In situations where the last write to a BTD stage only adds further particles from a few ranks, we need to pad with zero-block writes so ADIOS2
Putgets called.Backend details:
Putmeta-data winsTests
6 MPI ranks w/ CUDA on Summit with read-back as in #3389
jsrun -r 6 -a 1 -g 1 -c 7 -l GPU-CPU -d packed -b rs --smpiargs="-gpu" ./warpx.RZ.MPI.CUDA.DP.PDP.OPMD.PSATD.QED inputs.txtpython3 -c "from openpmd_viewer import OpenPMDTimeSeries; ts = OpenPMDTimeSeries('./diags/diag_btd/'); ts.get_particle(['x'], iteration=1)"Results:
developmentmasteras of98bef0ee88838c034832a1e280dfd555841462dcw/ c-blosc 2.6.1: also failsRequires this patch in openPMD-viewer: openPMD/openPMD-viewer#355
Related Issues
Putornladios/ADIOS2#3455